Report error logs from codecov upload fail #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev/gfdl #193 +/- ##
============================================
- Coverage 37.22% 36.95% -0.27%
============================================
Files 261 261
Lines 72499 71797 -702
Branches 13554 13457 -97
============================================
- Hits 26985 26533 -452
+ Misses 40514 40305 -209
+ Partials 5000 4959 -41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This isn't doing what it should, the report flag is not set. |
marshallward
force-pushed
the
codecov_err_report
branch
from
5b90789
to
764b679
Compare
|
The PR was modified to remove the conditional reporting based on The issue above was because we only set this variable for the FMS build. If we want to extend that variable, we can do it in another PR. |
Hallberg-NOAA
approved these changes
Aug 22, 2022
Failed codecov.io uploads now report the stderr output. This will allow us to start diagnosing the intermittent failures and, possibly, find a solution.
Hallberg-NOAA
force-pushed
the
codecov_err_report
branch
from
764b679
to
575595a
Compare
|
Given the nature of these changes, only the TC testing is impacted, so there is no need to go through the pipeline regression tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch extends the REPORT_ERROR_LOGS flag behavior to also report
the error log of failed codecov uploads.
I expect there's little we can do on our end, but more information will
at least help to understand the problem.